Skip to content

Commit

Permalink
First steps towards using vale (for now just fixing errors)
Browse files Browse the repository at this point in the history
  • Loading branch information
kellertuer committed Nov 16, 2023
1 parent da9743e commit 56873a9
Show file tree
Hide file tree
Showing 50 changed files with 395 additions and 306 deletions.
9 changes: 8 additions & 1 deletion .github/workflows/documenter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,14 @@ jobs:
restore-keys: |
${{ runner.os }}-${{ env.cache-name }}-
- name: "Documenter rendering (including Quarto)"
run: "docs/make.jl --quarto"
run: "docs/make.jl --quarto --prettyurls"
- name: "vale.sh spell check"
uses: errata-ai/vale-action@reviewdog
with:
files: docs/src
fail_on_error: true
filter_mode: nofilter
vale_flags: "--config=docs/.vale.ini"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
DOCUMENTER_KEY: ${{ secrets.DOCUMENTER_KEY }}
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,4 @@ docs/.CondaPkg
docs/src/tutorials/Optimize!_files
docs/src/tutorials/*.html
docs/src/changelog.md
docs/styles/Google
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ If you found a bug or want to propose a feature, we track our issues within the
### Add a missing method

There is still a lot of methods for within the optimization framework of `Manopt.jl`, may it be functions, gradients, differentials, proximal maps, step size rules or stopping criteria.
If you notice a method missing and can contribute an implementation, please do so!
If you notice a method missing and can contribute an implementation, please do so, we help with the necessary details.
Even providing a single new method is a good contribution.

### Provide a new algorithm
Expand All @@ -55,7 +55,7 @@ where also their reproducible Quarto-Markdown files are stored.
### Code style

We try to follow the [documentation guidelines](https://docs.julialang.org/en/v1/manual/documentation/) from the Julia documentation as well as [Blue Style](https://github.com/invenia/BlueStyle).
We run [`JuliaFormatter.jl`](https://github.com/domluna/JuliaFormatter.jl) on the repo in the way set in the `.JuliaFormatter.toml` file, which enforces a number of conventions consistent with the Blue Style.
We run [`JuliaFormatter.jl`](https://github.com/domluna/JuliaFormatter.jl) on the repository in the way set in the `.JuliaFormatter.toml` file, which enforces a number of conventions consistent with the Blue Style.

We also follow a few internal conventions:

Expand All @@ -68,5 +68,5 @@ We also follow a few internal conventions:
- There should be no dangling `=` signs.
- Always add a newline between things of different types (struct/method/const).
- Always add a newline between methods for different functions (including mutating/nonmutating variants).
- Prefer to have no newline between methods for the same function; when reasonable, merge the docstrings.
- Prefer to have no newline between methods for the same function; when reasonable, merge the documentation strings.
- All `import`/`using`/`include` should be in the main module file.
Loading

0 comments on commit 56873a9

Please sign in to comment.