Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where the retraction method in check_Hessianwas not passed on #343

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

kellertuer
Copy link
Member

This fixes #342.

@kellertuer kellertuer marked this pull request as ready for review January 6, 2024 15:06
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a24c869) 99.60% compared to head (01fb1c1) 99.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          69       69           
  Lines        6372     6372           
=======================================
  Hits         6347     6347           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellertuer kellertuer merged commit 40955df into master Jan 6, 2024
15 checks passed
@kellertuer kellertuer deleted the kellertuer/fix-check-Hessian branch May 4, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check_Hessian: retraction_method is not passed to gradient check
1 participant