-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce text checks (vale.sh) on Docstrings and comments #353
Conversation
…tangeling them here further.
# Conflicts: # docs/make.jl # ext/ManoptManifoldsExt/manifold_functions.jl
# Conflicts: # test/helpers/test_manifold_extra_functions.jl
# Conflicts: # src/helpers/checks.jl # test/solvers/test_particle_swarm.jl
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #353 +/- ##
==========================================
- Coverage 99.45% 99.22% -0.23%
==========================================
Files 69 69
Lines 6418 6194 -224
==========================================
- Hits 6383 6146 -237
- Misses 35 48 +13 ☔ View full report in Codecov by Sentry. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…anopt.jl into kellertuer/vale-on-code
# Conflicts: # src/plans/debug.jl # src/plans/plan.jl # test/plans/test_stopping_criteria.jl # tutorials/Optimize.qmd
….qmd` would be nice as well.
# Conflicts: # src/solvers/quasi_Newton.jl # src/solvers/subgradient.jl
Vale does not yet fully work, so I do not want to activate a CI on this yet. The main challenges are
Still. These first steps
Since this does not add new features, but just rewrites docs, this will not be a new version, but be on master until a next feature justifying a new version comes along. |
Would it be possible to enable Vale on CI only for comments but not for strings and qmd files? BTW, I most likely won't look over all these changes so merge when you think it's ready. |
Sure it is a lot of changes, no worries – and most of them are even mainly unifying formatting of Keyword arguments and such. For comments and not strings – in theory yes, in practice, I can not find how to do that. |
Co-authored-by: Mateusz Baran <[email protected]>
This PR slowly works through all doc strings to fulfil the vale.sh rules the documentation already follows, because since the 3.0 version vale.sh works on Julia files and recognises its doc-strings.