Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proximal Point Method #410

Merged
merged 8 commits into from
Sep 4, 2024
Merged

Proximal Point Method #410

merged 8 commits into from
Sep 4, 2024

Conversation

kellertuer
Copy link
Member

@kellertuer kellertuer commented Sep 3, 2024

This is maybe a bit of an academic method, but probably still good to have as a comparison at least, as requested in #252.

I am mainly missing test coverage here, since I need a nice problem to test this on.

🛣️ Roadmap

  • 🛠️ adapt the prox objective
  • 🛠️ add a state for the solver
  • 🛠️implement method
  • 📚add documentation and render it
  • 📝 Update Changelog, bump version.
  • 🧪test coverage

@kellertuer kellertuer changed the title Kellertuer/proximal point Proximal Point Method Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.90%. Comparing base (39c10e3) to head (fa89f58).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #410   +/-   ##
=======================================
  Coverage   99.90%   99.90%           
=======================================
  Files          77       78    +1     
  Lines        8220     8271   +51     
=======================================
+ Hits         8212     8263   +51     
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kellertuer kellertuer added the Ready-for-Review A label for pull requests that are feature-ready label Sep 4, 2024
@kellertuer kellertuer merged commit 82f31f8 into master Sep 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant