Update ManifoldDiff.jl compat to 0.4 and CI#23
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
+ Coverage 93.03% 93.26% +0.22%
==========================================
Files 11 11
Lines 1191 1187 -4
==========================================
- Hits 1108 1107 -1
+ Misses 83 80 -3 ☔ View full report in Codecov by Sentry. |
|
@kellertuer I have no idea why building the tutorial gets stuck on CI. Could you try it on your computer? I still don't have a working quarto installation. |
|
Hm, clear cache here, and maybe also let the examples run on 1.11? |
|
There are no caches in this repository and the example should work fine on Julia 1.10. |
|
Ok, I can try, but probably only tomorrow, just came home and first need something to eat. |
|
Bumped all versions (Julia for documenter and quarto, quarto, version on the example manifest), my local version is on 15/21 in the nb that got stuck, a few seem to run a bit slow, yeah. |
|
Yeah maybe the subsolver calls take too long on cell 20/21, but I have no clue how to directly debug that for now. |
|
Maybe just setting a lower limit of iterations would be fine? At least as a temporary solution until you have time to investigate. |
|
Will check, the current parameters are the ones from the paper, so it would be a pity to change that, but well, maybe that is what it is and it turns out nearly nothing is ever reproducible. |
|
It might be a good idea to revive this PR a bit? |
|
Ah, the newest version should already run on 0.4 now I think? |
|
This PR also has a few other minor changes |
|
Ah, I see. Sure feel free to check that it works with Manopt 0.5.6 once that is registered, maybe even good since for now we. have this circular dependency between those two. |
|
I've fixed the Riemannian difference-of-convex example but the Riemannian mean example still uses some old Manopt internals, could you take a look @kellertuer ? |
|
Sure but maybe not tomorrow |
…he factory for Armijo (since 0.5).
|
Luckily I have my own changelog in mind and document constructors, I am not sure why the CG constructor was still on 0.3 style (nearly no keywords); It now has keywords, then I just had to adapt Armijo to the new Factory idea and then it ran fine. I did also add a “Tech” section to print package versions. |
|
OK, I think we can merge this now 🙂 |
No description provided.