Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README not to encourage type-piracy #149

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

hyrodium
Copy link
Collaborator

This PR just removes the paragraph that encourages type-piracy. (alternative to #56)

The removed paragraph is:

This package is intended to implement a "minimal" foundation for intervals upon which other packages might build. In particular, we encourage type-piracy for the reason that only one interval package can unambiguously define the .. and ± operators (see below).

The reasons why I would like to remove that are:

  • Generally, we would like to avoid type-piracy
  • If someone wants some operations to Interval, PRs are welcome.
    • If the new operation does not fit Interval, you can just add the method to your wrapper type. (e.g. struct YourInterval{L,R,T} i::Interval{L,R,T} end)

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (031a18d) 99.17% compared to head (09712d7) 99.17%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   99.17%   99.17%           
=======================================
  Files           4        4           
  Lines         242      242           
=======================================
  Hits          240      240           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant