Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add min/maximum(abs) #196

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add min/maximum(abs) #196

wants to merge 3 commits into from

Conversation

aplavin
Copy link
Contributor

@aplavin aplavin commented Nov 25, 2024

No description provided.

@aplavin aplavin changed the title min/maximum(abs) add min/maximum(abs) Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.65%. Comparing base (13c76e1) to head (266082c).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
src/IntervalSets.jl 84.37% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   99.11%   96.65%   -2.46%     
==========================================
  Files           6        6              
  Lines         225      299      +74     
==========================================
+ Hits          223      289      +66     
- Misses          2       10       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hyrodium hyrodium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a comment to improve the test coverage. Other changes look great to me!

Co-authored-by: Yuto Horikawa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants