DomainSets.jl #19
Closed
DomainSets.jl #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
- Coverage 36.47% 35.91% -0.57%
==========================================
Files 29 29
Lines 636 632 -4
==========================================
- Hits 232 227 -5
- Misses 404 405 +1
Continue to review full report at Codecov.
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dependency on DomainSets.jl. DomainSets also depends on CompositeTypes, which makes it easy to work with "components". This could be independently useful for us, for things like product measures or superpositions.
Q&A
What's the point of this?
In lots of cases, we need to work with the support of a given measure. It's important to have a way to test for inclusion and take sums, products, intersections, and unions. We currently have a very hacky approach to this, but DomainSets is built for exactly this purpose. Without it or something similar, we'd eventually have to build something like it at some point. Better to re-use an existing package, both for us and for the ecosystem as a whole.
Will this affect ManifoldMeasures?
My guess is that it should be straightforward to set up some basic functionality converting between the two, in cases where that makes sense. But we need to confirm this with @sethaxen.
What about the StaticArrays dependency?
Yes, DomainSets depends on StaticArrays. The potential concern here is that MeasureBase is intended to be relatively light-weight. Whather this is a problem is maybe more of a question for you, for example @torfjelde and @devmotion have both pointed out the importance of a lightweight core package.
I don't know if StaticArrays could be made an optional dependency of DomainSets, but I've raised the issue in
JuliaApproximation/DomainSets.jl#91.