Skip to content

Conversation

@AuroraDysis
Copy link
Contributor

@AuroraDysis AuroraDysis commented Dec 31, 2024

Fix #15

(Xsum) pkg> test
     Testing Xsum
      Status `/private/var/folders/t6/g4hn6yfs42gc9xf11bzk77200000gn/T/jl_SQkyal/Project.toml`
  [1fd64df0] Xsum v1.2.0 `~/Projects/Xsum.jl`
  [e979a739] xsum_jll v3.0.0+0
  [9a3f8284] Random v1.11.0
  [8dfed614] Test v1.11.0
      Status `/private/var/folders/t6/g4hn6yfs42gc9xf11bzk77200000gn/T/jl_SQkyal/Manifest.toml`
  [692b3bcd] JLLWrappers v1.7.0
  [21216c6a] Preferences v1.4.3
  [1fd64df0] Xsum v1.2.0 `~/Projects/Xsum.jl`
  [e979a739] xsum_jll v3.0.0+0
  [56f22d72] Artifacts v1.11.0
  [2a0f44e3] Base64 v1.11.0
  [ade2ca70] Dates v1.11.0
  [b77e0a4c] InteractiveUtils v1.11.0
  [8f399da3] Libdl v1.11.0
  [56ddb016] Logging v1.11.0
  [d6f4376e] Markdown v1.11.0
  [de0858da] Printf v1.11.0
  [9a3f8284] Random v1.11.0
  [ea8e919c] SHA v0.7.0
  [9e88b42a] Serialization v1.11.0
  [fa267f1f] TOML v1.0.3
  [8dfed614] Test v1.11.0
  [4ec0a83e] Unicode v1.11.0
     Testing Running tests...
Test Summary: | Pass  Total  Time
xsum          |   12     12  0.6s
Test Summary: | Pass  Total  Time
XAccumulator  |   10     10  0.1s
     Testing Xsum tests passed 

@codecov
Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.80%. Comparing base (0eef0d9) to head (d1569f7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   87.80%   87.80%           
=======================================
  Files           2        2           
  Lines          82       82           
=======================================
  Hits           72       72           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@inkydragon inkydragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I've tested this pr with julia +nightly:

  • WSL, Julia Version 1.12.0-DEV.1810 (Linux (x86_64-linux-gnu))
  • Win11, Julia Version 1.12.0-DEV.1810 (Windows (x86_64-w64-mingw32))

All tests passed, everything look good.

@stevengj stevengj merged commit e8874c4 into JuliaMath:master Dec 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug fixes to move here

3 participants