Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert that extension size is divisible by 16 #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

azraq27
Copy link

@azraq27 azraq27 commented Aug 5, 2022

The current implementation of esize makes an @assert check that the size is not divisible by 16, which I believe is the opposite of what is intended.

Minimal example:

dset = niread(fname)
ex = dset.extensions[1]
NIfTI.esize(ex)

AssertionError: NIfTIExtension has innapropriate size. See docstrings for more details.

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #62 (bdad34e) into master (06d4ce3) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   52.27%   52.27%           
=======================================
  Files           6        6           
  Lines         549      549           
=======================================
  Hits          287      287           
  Misses        262      262           
Impacted Files Coverage Δ
src/extensions.jl 15.78% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant