-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate other PRs for fixing extensions #123
Conversation
Test this please |
2 similar comments
Test this please |
Test this please |
Hi @PhilipFackler please feel free to rebase main, resolve conflicts and test again. Let's see if PR #126 fixes the issue with AMD GPU CI. Thanks for the effort. |
Test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @PhilipFackler just a couple of things:
- AMDGPU CI is failing due to dependencies in KA?
- We should sync up on CI code formatting using JuliaFormatter.jl
Test this please |
Test this please |
Test this please |
@PhilipFackler the AMDGPU.jl version is restricted to > 1.0 . Should we try 0.8 in JACC's Project.toml ? @jpsamaroo any ideas of the failure on CI AMD GPU deps ? |
We had 0.8 in both the Project.toml and in runtests.jl. I was trying to see if updating it would make a difference with the error we're seeing. I need to just get on an AMD system and run it myself. I wasn't able to login to cousteau today. I'll try again later this week. |
Test this please |
1 similar comment
Test this please |
Using backend struct tags like #62 (following KernelAbstractions) and backend dispatch from #118 so we don't overwrite names. Addresses #122