Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate other PRs for fixing extensions #123

Merged
merged 7 commits into from
Oct 30, 2024

Conversation

PhilipFackler
Copy link
Collaborator

@PhilipFackler PhilipFackler commented Oct 18, 2024

Using backend struct tags like #62 (following KernelAbstractions) and backend dispatch from #118 so we don't overwrite names. Addresses #122

@PhilipFackler
Copy link
Collaborator Author

Test this please

2 similar comments
@williamfgc
Copy link
Collaborator

Test this please

@williamfgc
Copy link
Collaborator

Test this please

@williamfgc
Copy link
Collaborator

Hi @PhilipFackler please feel free to rebase main, resolve conflicts and test again. Let's see if PR #126 fixes the issue with AMD GPU CI. Thanks for the effort.

@PhilipFackler
Copy link
Collaborator Author

Test this please

Copy link
Collaborator

@williamfgc williamfgc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @PhilipFackler just a couple of things:

  1. AMDGPU CI is failing due to dependencies in KA?
  2. We should sync up on CI code formatting using JuliaFormatter.jl

@PhilipFackler
Copy link
Collaborator Author

Test this please

@PhilipFackler
Copy link
Collaborator Author

Test this please

@PhilipFackler
Copy link
Collaborator Author

Test this please

@williamfgc
Copy link
Collaborator

@PhilipFackler the AMDGPU.jl version is restricted to > 1.0 . Should we try 0.8 in JACC's Project.toml ? @jpsamaroo any ideas of the failure on CI AMD GPU deps ?

@PhilipFackler
Copy link
Collaborator Author

@PhilipFackler the AMDGPU.jl version is restricted to > 1.0 . Should we try 0.8 in JACC's Project.toml ?

We had 0.8 in both the Project.toml and in runtests.jl. I was trying to see if updating it would make a difference with the error we're seeing. I need to just get on an AMD system and run it myself. I wasn't able to login to cousteau today. I'll try again later this week.

@PhilipFackler
Copy link
Collaborator Author

Test this please

1 similar comment
@PhilipFackler
Copy link
Collaborator Author

Test this please

@williamfgc williamfgc merged commit cb642f7 into JuliaORNL:main Oct 30, 2024
6 checks passed
@williamfgc
Copy link
Collaborator

Merges and closes #118, #114, #86, #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants