Skip to content

Conversation

@pnavaro
Copy link
Contributor

@pnavaro pnavaro commented Jan 21, 2025

Hi, I need this function for my problem, so I added it to the package. I fixed some tests in functions already wrapped by matching examples in pot documentation. I already did this for another function, I hope I followed the contribution rules correctly.

Pierre

I also fix tests in `sinkhorn_unbalanced` and `sinkhorn_unbalanced2`
Fix problems in doc generation
@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.35%. Comparing base (7c72cf8) to head (8d7b1c6).

Files with missing lines Patch % Lines
src/lib.jl 25.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
- Coverage   87.50%   74.35%   -13.15%     
===========================================
  Files           3        3               
  Lines          32       39        +7     
===========================================
+ Hits           28       29        +1     
- Misses          4       10        +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coveralls
Copy link

coveralls commented Jan 21, 2025

Pull Request Test Coverage Report for Build 19707569252

Details

  • 2 of 5 (40.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-8.0%) to 85.294%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib.jl 2 5 40.0%
Totals Coverage Status
Change from base Build 9870943894: -8.0%
Covered Lines: 29
Relevant Lines: 34

💛 - Coveralls

Introduces the partial_wasserstein2 function in lib.jl, wrapping the corresponding PythonOT method, and exports it in PythonOT.jl for external use.
Introduces the partial_wasserstein function to the Julia API, wrapping pot.partial.partial_wasserstein2. Also updates the package version to 0.1.9 and exports the new function.
Exports and implements the entropic_partial_gromov_wasserstein2 function, providing a Julia wrapper for the corresponding POT library method.
Introduces the entropic_partial_gromov_wasserstein function to the API and exports it. This provides access to the corresponding functionality from the underlying pot.partial module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants