Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added broadcasting #17

Merged
merged 4 commits into from
Sep 28, 2022
Merged

Conversation

zlaouar
Copy link
Contributor

@zlaouar zlaouar commented Sep 28, 2022

#16

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 64.18% // Head: 68.23% // Increases project coverage by +4.04% 🎉

Coverage data is based on head (185f21b) compared to base (44241d7).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   64.18%   68.23%   +4.04%     
==========================================
  Files          10       10              
  Lines         416      447      +31     
==========================================
+ Hits          267      305      +38     
+ Misses        149      142       -7     
Impacted Files Coverage Δ
src/visualization.jl 90.81% <100.00%> (+20.48%) ⬆️
src/distance_cache.jl 68.18% <0.00%> (-3.25%) ⬇️
src/problem_gen.jl 71.42% <0.00%> (-2.65%) ⬇️
src/states.jl 47.61% <0.00%> (-2.39%) ⬇️
src/initial.jl 25.92% <0.00%> (-2.08%) ⬇️
src/transition.jl 51.38% <0.00%> (-0.73%) ⬇️
src/heuristics.jl 0.00% <0.00%> (ø)
src/obs_models.jl 98.43% <0.00%> (+0.22%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zsunberg
Copy link
Member

Ugh, the tests are failing because of the huge terrible latex dependency.

In the long term, we should use Compose.jl or something more lightweight for visualization.

In the short term, @zlaouar can you add a try catch block in deps/build.jl to catch errors when installing latex?

@zsunberg zsunberg merged commit 60b14f6 into JuliaPOMDP:master Sep 28, 2022
@zsunberg
Copy link
Member

Thanks @zlaouar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants