Add quaternions page #39
Conversation
|
@KronosTheLate Do you have any thoughts on this PR? Should we wait for some other reviews? |
|
@moble Hi, this PR adds a new comparison page for quaternions. I mentioned you because you are maintaining Quaternionic.jl. Feel free to comment if my comparison is misleading or incorrect. (sorry for lacking an explanation in the first comment!) |
|
Yep, I actually started a review when I saw your first comment but didn't finish it. :) Will finish it in the next hour or so. |
|
I have to admit, I am in the middle of some quite intense exam preparations. But I do not expect development to stop only for my sake. If we can get you both as independent actors to "sign off" on this PR, I am all good with merging it. The PR author has obviously approved it, so as soon as @moble gives the green light, we have two independant thumbs up, and @hyrodium is free to merge it. |
Co-authored-by: Mike Boyle <[email protected]>
Co-authored-by: Mike Boyle <[email protected]>
|
Awesome! Just skimming the page, I already learnt a think or two about quaternions and their state in the Julia package ecosystem. Thanks <3 |
This PR fixes #38.
(cc: @moble)