Support bind port hints #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise all the workers would try to bind to the same port, which would cause an error.
JamesWrigley
force-pushed
the
multiple-workers
branch
from
f4c2a87 to
cdabed6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19 +/- ##
==========================================
- Coverage 88.24% 88.14% -0.11%
==========================================
Files 11 11
Lines 2068 2084 +16
==========================================
+ Hits 1825 1837 +12
- Misses 243 247 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick explanation:
addprocs([("machine 10.1.1.1:9000", 2)])by using the bind port as a port hint for all the other workers.Fixes JuliaLang/Distributed.jl#119. If this is merged I'll backport it to Distributed.