-
Notifications
You must be signed in to change notification settings - Fork 122
Prevent infinite recursion of unit by adding a method unit(::Type{Any}) #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sostock
merged 14 commits into
JuliaPhysics:master
from
SeSodesa:make-unit-function-total
Sep 15, 2025
Merged
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
330869f
Define unit(::Any)m unit(::Funciton) and add a type restriction to un…
SeSodesa 51e81a5
test/dates: assume NoUnits instead of MethodErrors in the case of Dat…
SeSodesa 4f2bf7f
Loosen the type restrictions of unit(::Type{Missing,T})
SeSodesa c230a6a
Fully qualify Dates.FixedPeriod in type restriction of method unit(x:…
SeSodesa fe1e225
Revert the Dates-related tests to throw MethodErrors instead of testi…
SeSodesa 156ffe2
If a unit call bubbles up to unit(::Any), throw a DomainError
SeSodesa b43536b
Remove now-unnecessary comment about type restriction from unit(::Typ…
SeSodesa e071b61
Remove method unit(::Any), and move unit(::Type{Any}) for docstring p…
SeSodesa 108bc4e
Change Dates-related tests to expect MethodErrors again, after the re…
SeSodesa 16c7404
Shorten error message thrown by unit(Any)
SeSodesa 6320332
Replace docstring of unit(::Type{Any}) with a simple comment
SeSodesa 6af1980
Take Julia 1.6 compatibility into account with the unit(Any) error me…
SeSodesa 7ea4b1f
Follow code style of project
SeSodesa 48b9629
Further code style changes
SeSodesa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.