Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vrep points with rays #239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

vrep points with rays #239

wants to merge 1 commit into from

Conversation

blegat
Copy link
Member

@blegat blegat commented Jan 24, 2021

Need to add test, it came up when I tried doing convexhull([1], Ray([1])) but its output does not contain the origin in the points which is inconsistent with convexhull([1], Ray([1]), Line([1])). Maybe convexhull with rays and lines should not be allowed, it's a bit ambiguous, convexhull(points) + cone and convexhull(points, cone) are less ambiguous.

@codecov
Copy link

codecov bot commented Jan 24, 2021

Codecov Report

Merging #239 (45a1388) into master (b6490a2) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   89.48%   89.41%   -0.08%     
==========================================
  Files          38       38              
  Lines        2359     2361       +2     
==========================================
  Hits         2111     2111              
- Misses        248      250       +2     
Impacted Files Coverage Δ
src/vecrep.jl 95.74% <0.00%> (-4.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6490a2...45a1388. Read the comment docs.

@blegat blegat force-pushed the master branch 2 times, most recently from 4dda979 to 687831d Compare February 15, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant