Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Write empty Deps.toml and Compat.toml files, but don't write empty WeakDeps.toml or WeakCompat.toml files" #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Revert "Write empty Deps.toml and Compat.toml files, but don't write empty WeakDeps.toml or WeakCompat.toml files" #84

wants to merge 2 commits into from

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Feb 17, 2023 •
edited
Loading

@DilumAluthge
Revert "Write empty Deps.toml and Compat.toml files, but don't wr…
e57a354 
…ite empty `WeakDeps.toml` or `WeakCompat.toml` files (#82)"

This reverts commit 05fd1ff.
@DilumAluthge
Add some comments about how it is intentional that we don't write cer…
13adcde 
…tain empty TOML files
@DilumAluthge DilumAluthge marked this pull request as ready for review February 25, 2023 01:04
@DilumAluthge
Copy link
Member Author

@KristofferC This is now ready for review.

@DilumAluthge DilumAluthge mentioned this pull request Feb 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkottary nkottary nkottary approved these changes

@KristofferC KristofferC Awaiting requested review from KristofferC

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DilumAluthge @nkottary