use bsdtar from LibArchive_jll

JuliaReinforcementLearning · Jun 23, 2020 · 36cff17 · 36cff17 · jbrea · Jun 23, 2020
1 parent 6f0b7f5
commit 36cff17
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,16 +1,18 @@
 name = "ArcadeLearningEnvironment"
 uuid = "b7f77d8d-088d-5e02-8ac0-89aab2acc977"
-version = "0.2.2"
+version = "0.2.3"
 
 [deps]
 ArcadeLearningEnvironment_jll = "52cbb755-00ff-5a24-b23e-8a91c598877e"
+LibArchive_jll = "1e303b3e-d4db-56ce-88c4-91e52606a1a8"
 MD5 = "6ac74813-4b46-53a4-afec-0b5dc9d7885c"
 Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
 
 [compat]
-julia = "1.4"
-MD5 = "0.2"
 ArcadeLearningEnvironment_jll = "0.6"
+LibArchive_jll = "3"
+MD5 = "0.2"
+julia = "1.3, 1.4"
 
 [extras]
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

diff --git a/README.md b/README.md
@@ -36,6 +36,7 @@ paper to acknowledge the work that went into ALE.
 ## Installation
 
 The package automatically downloads version 0.6.1 of the ArcadeLearningEnvironment
+and the ROMS from www.atarimania.com.
 
 ```julia
 Pkg.add("ArcadeLearningEnvironment")
@@ -47,6 +48,7 @@ Pkg.add("ArcadeLearningEnvironment")
 ```julia
 using ArcadeLearningEnvironment
 
+getROMList()
 
 episodes = 50
 

diff --git a/deps/build.jl b/deps/build.jl
@@ -1,4 +1,5 @@
 using MD5
+using LibArchive_jll
 using Pkg.Artifacts
 
 function import_roms(dir)
@@ -36,8 +37,10 @@ if rom_hash == nothing || !artifact_exists(rom_hash)
         download("https://raw.githubusercontent.com/mgbellemare/Arcade-Learning-Environment/v0.6.1/md5.txt", joinpath(artifact_dir, "md5.txt"))
         download("http://www.atarimania.com/roms/Roms.rar", joinpath(artifact_dir, "Roms.rar"))
         cd(artifact_dir)
-        run(`7z e $(joinpath(artifact_dir, "Roms.rar"))`)
-        run(`7z x $(joinpath(artifact_dir, "ROMS.zip"))`)
+        bsdtar() do exe
+            run(`$exe -xf $(joinpath(artifact_dir, "Roms.rar"))`)
+            run(`$exe -xf $(joinpath(artifact_dir, "ROMS.zip"))`)
+        end
         rm(joinpath(artifact_dir, "Roms.rar"))
         rm(joinpath(artifact_dir, "ROMS.zip"))
         rm(joinpath(artifact_dir, "HC ROMS.zip"))