Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

observations(env) #10

Closed
zsunberg opened this issue Jun 16, 2020 · 4 comments · Fixed by #23
Closed

observations(env) #10

zsunberg opened this issue Jun 16, 2020 · 4 comments · Fixed by #23

Comments

@zsunberg
Copy link
Member

Should we add observations(env) as an optional interface function to return the observation space?

@mkschleg
Copy link

With this do we want to provide an abstract type for observation spaces? Or just leave that up to the environment designers?

Having a standard observation space with an interface could make defining models for agents easier. But another potential design is to just dispatch on the env when specifying the agent's internals.

@zsunberg
Copy link
Member Author

Started #15 for discussion of spaces.

But another potential design is to just dispatch on the env when specifying the agent's internals.

Can you elaborate on this? (possibly in #15)

@mkschleg
Copy link

Thanks! Didn't see this!

@zsunberg
Copy link
Member Author

@mkschleg I made it after your post, so you couldn't have seen it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants