Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.2 #23

Merged
merged 2 commits into from
Jul 6, 2020
Merged

Version 0.2 #23

merged 2 commits into from
Jul 6, 2020

Conversation

zsunberg
Copy link
Member

@zsunberg zsunberg commented Jun 30, 2020

Added @provide to fix #1

Added the following functions

I did not include setstate! #9 , yet, because there is still a question about whether we want that or reset!(env, state).

I did not add observe #12 yet, because I don't understand the exact semantics of it. If someone can write a docstring for it that is unambiguous from both the environment writer and algorithm writer's perspective, then I think we could add it.

I did not set up Documenter.jl docs yet #24 , but I don't think this is necessary to be useful to release.

@zsunberg
Copy link
Member Author

zsunberg commented Jul 1, 2020

I'm requesting a couple of reviews, but if you want to review, please don't hesitate to jump in!

@zsunberg zsunberg requested review from findmyway and jbrea July 1, 2020 00:34
@zsunberg zsunberg changed the title WIP: Version 0.2 Version 0.2 Jul 1, 2020
@findmyway
Copy link
Member

In #20 @jonathan-laurent mentioned that some core common interfaces in single-agent and multi-agent environments can be contained here. So he may check it again in case some important functions are missing.

@jonathan-laurent
Copy link

I just made a proposal for supporting two-players, zero-sum games.

Copy link

@jbrea jbrea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this proposal!

@zsunberg
Copy link
Member Author

zsunberg commented Jul 6, 2020

OK, going to merge this but not going to register a new version. Will immediately start a PR with the changes discussed in #20 and #25

@zsunberg zsunberg merged commit 8d74e3d into master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants