Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU Code Migration Part 2 #1023

Closed
wants to merge 43 commits into from
Closed

Conversation

jeremiahpslewis
Copy link
Member

PR Checklist

  • Update NEWS.md?
  • Unit tests for all structs / functions?
  • Integration and correctness tests using a simple env?
  • PR Review?
  • Add or update documentation?
  • Write docstrings for new methods?

@jeremiahpslewis jeremiahpslewis changed the title Rearrange approximator setup GPU Code Migration Part 2 Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 38.70968% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 12.09%. Comparing base (1d3c7da) to head (dee775c).

❗ Current head dee775c differs from pull request most recent head 05e125b. Consider uploading reports for the commit 05e125b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            main    #1023       +/-   ##
==========================================
+ Coverage   0.00%   12.09%   +12.09%     
==========================================
  Files        218      223        +5     
  Lines       7721     7857      +136     
==========================================
+ Hits           0      950      +950     
+ Misses      7721     6907      -814     
Files Coverage Δ
...arningCore/src/policies/learners/target_network.jl 85.00% <100.00%> (ø)
...rcementLearningCore/test/policies/approximators.jl 100.00% <100.00%> (+100.00%) ⬆️
src/ReinforcementLearningCore/test/utils/device.jl 0.00% <ø> (ø)
...ningCore/src/policies/learners/abstract_learner.jl 54.54% <54.54%> (ø)
...Core/src/policies/learners/tabular_approximator.jl 0.00% <0.00%> (ø)

... and 25 files with indirect coverage changes

@jeremiahpslewis jeremiahpslewis force-pushed the jpsl/rlcore-gpu-tweaks branch from 4abea61 to 8f970c7 Compare March 5, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant