Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spell check CI errors #1027

Merged

Conversation

joelreymont
Copy link
Contributor

@joelreymont joelreymont commented Mar 6, 2024

Fixes #1026.

Note that .cspell/julia_words.txt absolutely must be sorted!

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.57%. Comparing base (1d3c7da) to head (ab949dc).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            main    #1027       +/-   ##
==========================================
+ Coverage   0.00%   23.57%   +23.57%     
==========================================
  Files        218      231       +13     
  Lines       7721     7988      +267     
==========================================
+ Hits           0     1883     +1883     
+ Misses      7721     6105     -1616     
Files Coverage Δ
...ntLearningCore/src/policies/agent/offline_agent.jl 90.62% <100.00%> (+90.62%) ⬆️
...forcementLearningCore/src/policies/approximator.jl 87.50% <100.00%> (+87.50%) ⬆️
...c/ReinforcementLearningCore/test/policies/agent.jl 100.00% <100.00%> (ø)

... and 67 files with indirect coverage changes

@jeremiahpslewis jeremiahpslewis enabled auto-merge (squash) March 6, 2024 15:07
@jeremiahpslewis jeremiahpslewis merged commit 7ecfb2e into JuliaReinforcementLearning:main Mar 6, 2024
26 checks passed
@joelreymont joelreymont deleted the spell-check branch March 6, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Should spell check be dropped or fixed?
2 participants