Drop devmode, prepare RL.jl v0.11 for release #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1035 +/- ##
===========================================
+ Coverage 12.74% 24.05% +11.31%
===========================================
Files 229 230 +1
Lines 7903 7970 +67
===========================================
+ Hits 1007 1917 +910
+ Misses 6896 6053 -843
|
|
@HenriDeh would love your thoughts |
HenriDeh
previously approved these changes
Mar 11, 2024
|
|
||
| This project contains updated, tested algorithms compatible with ReinforcementLearning.jl v0.11+. | ||
|
|
||
| Unlike ReinforcementLearningZoo, the algorithms here have been domesticated. |
Comment on lines
+9
to
+12
| else | ||
| using CUDA, cuDNN | ||
| CUDA.allowscalar(false) | ||
| end |
There was a problem hiding this comment.
Not a priority but there's also an AMD gpu support package now. I don't know if it is mature enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do
Description