Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reset and stop conditions #1046

Merged
merged 13 commits into from
Mar 14, 2024
Merged

Fix reset and stop conditions #1046

merged 13 commits into from
Mar 14, 2024

Conversation

jeremiahpslewis
Copy link
Member

@jeremiahpslewis jeremiahpslewis commented Mar 13, 2024

This pull request updates the reset and stop conditions in the code to use a consistent check! in-place interface. It is a step on the way to getting a high level of test coverage

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 55.64%. Comparing base (4c935e7) to head (a038d63).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1046      +/-   ##
==========================================
+ Coverage   55.33%   55.64%   +0.30%     
==========================================
  Files          69       69              
  Lines        2727     2728       +1     
==========================================
+ Hits         1509     1518       +9     
+ Misses       1218     1210       -8     
Files Coverage Δ
...forcementLearningCore/src/core/reset_conditions.jl 100.00% <100.00%> (+80.00%) ⬆️
src/ReinforcementLearningCore/src/core/run.jl 94.73% <100.00%> (ø)
...mentLearningCore/src/policies/agent/multi_agent.jl 96.77% <100.00%> (ø)
...ntLearningCore/src/policies/agent/offline_agent.jl 90.62% <100.00%> (ø)
.../src/environments/examples/GraphShortestPathEnv.jl 57.44% <ø> (ø)
...nforcementLearningCore/src/core/stop_conditions.jl 80.64% <87.50%> (ø)

@jeremiahpslewis jeremiahpslewis merged commit d10fae7 into main Mar 14, 2024
13 checks passed
@jeremiahpslewis jeremiahpslewis deleted the jpsl/reset branch March 14, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants