-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make FluxApproximator
work with QBasedPolicy
#1075
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1075 +/- ##
===========================================
+ Coverage 31.26% 81.57% +50.31%
===========================================
Files 72 3 -69
Lines 2783 38 -2745
===========================================
- Hits 870 31 -839
+ Misses 1913 7 -1906 |
legal_action_space_mask
default methods
legal_action_space_mask
default methodslegal_action_space_mask
methods for MinimalActionSet
case
legal_action_space_mask
methods for MinimalActionSet
caselegal_action_space_mask
methods for MinimalActionSet
case and clean up state
syntax
legal_action_space_mask
methods for MinimalActionSet
case and clean up state
syntaxlegal_action_space_mask
methods for MinimalActionSet
case and clean up state
syntax so FluxApproximator
works with QBasedPolicy
@HenriDeh Would love your review on this when you have a chance. :) |
legal_action_space_mask
methods for MinimalActionSet
case and clean up state
syntax so FluxApproximator
works with QBasedPolicy
FluxApproximator
work with QBasedPolicy
src/ReinforcementLearningEnvironments/src/environments/examples/TigerProblemEnv.jl
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
Thanks! Added an explanation. |
I think you did not push it ? |
Sorry, was unclear. I meant a comment to your review question |
legal_action_space_mask
methods forMinimalActionSet
casestate
syntax soFluxApproximator
works withQBasedPolicy
state(env, Observation, DefaultPlayer)
calls in RLEnvsPR Checklist