Use Trajectories.jl instead #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'm confused: what happened to |
|
Should be added back soon. This package is slowly moving towards v0.11 You may track the progress here: #614 |
|
As always, contributions are welcomed! |
|
what's the reason to move away from |
AbstractLearner was removed by accident. (And is already added back, it's just that the rename part is not reverted yet) I find the old NeuralNetworkApproximator is general enough. So simply removed the abstract type and renamed it to Approximator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to split out trajectories related codes and simplify the code logic in RLCore