Fix nothing not in EmptySpace. (#27)

* Add EmptySpace. * Fix nothing not in EmptySpace. * Fix nothing value instead of Nothing type.
JuliaReinforcementLearning · Feb 26, 2020 · 3d7855f · 3d7855f · findmyway · Feb 26, 2020
1 parent 3fa05d6
commit 3d7855f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/implementations/spaces/empty_space.jl b/src/implementations/spaces/empty_space.jl
@@ -2,7 +2,7 @@ export EmptySpace
 
 struct EmptySpace <: AbstractSpace end
 
-Base.eltype(s::EmptySpace) = nothing
+Base.eltype(s::EmptySpace) = Nothing
 Base.length(s::EmptySpace) = 0
-Base.in(x, s::EmptySpace) = false
+Base.in(x, s::EmptySpace) = x isa Nothing
 Random.rand(rng::AbstractRNG, s::EmptySpace) = nothing
diff --git a/test/spaces.jl b/test/spaces.jl
@@ -28,6 +28,12 @@
         @test s3 isa DiscreteSpace
     end
 
+    @testset "EmptySpace" begin
+      e = EmptySpace()
+      @test e isa EmptySpace
+      @test nothing in e
+    end
+
     @testset "MultiDiscreteSpace" begin
         @test_throws ArgumentError MultiDiscreteSpace([2, -1, 3])
         @test_throws ArgumentError MultiDiscreteSpace([2, -1, 3])