Fix SLART type (#224)

* Fix SLART type

* Add test case for SLART

* Fix order of CircularArraySLARTTrajectory arguments

* Remove dumb line

src/policies/agents/trajectories/abstract_trajectory.jl

@@ -60,7 +60,7 @@ end
 const SART = (:state, :action, :reward, :terminal)
 const SARTS = (:state, :action, :reward, :terminal, :next_state)
 const SARTSA = (:state, :action, :reward, :terminal, :next_state, :next_action)
-const SLART = (:state, :legal_actions_mask, :action, :reward, :terminal, :next_state)
+const SLART = (:state, :legal_actions_mask, :action, :reward, :terminal)
 const SLARTSL = (
     :state,
     :legal_actions_mask,

src/policies/agents/trajectories/trajectory.jl

@@ -94,16 +94,16 @@ const CircularArraySLARTTrajectory = Trajectory{
 CircularArraySLARTTrajectory(;
     capacity::Int,
     state = Int => (),
-    action = Int => (),
     legal_actions_mask,
+    action = Int => (),
     reward = Float32 => (),
     terminal = Bool => (),
 ) = merge(
     CircularArrayTrajectory(;
         capacity = capacity + 1,
         state = state,
-        action = action,
         legal_actions_mask = legal_actions_mask,
+        action = action,
     ),
     CircularArrayTrajectory(; capacity = capacity, reward = reward, terminal = terminal),
 )

test/components/trajectories.jl

@@ -48,6 +48,17 @@
         @test t[:reward] == [2, 3, 4]
     end
 
+    @testset "CircularArraySLARTTrajectory" begin
+        t = CircularArraySLARTTrajectory(
+            capacity = 3,
+            state = Matrix{Float32} => (2,2),
+            legal_actions_mask = Vector{Bool} => (4, ),
+        )
+
+        # test instance type is same as type
+        @test isa(t, CircularArraySLARTTrajectory)
+    end
+
     @testset "ReservoirTrajectory" begin
         # test length
         t = ReservoirTrajectory(3; a = Array{Float64,2}, b = Bool)