Skip to content

Update breakage: use organization-wide workflow - #235

Merged
amontoison merged 1 commit into
JuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage
Jul 22, 2026
Merged

Update breakage: use organization-wide workflow#235
amontoison merged 1 commit into
JuliaSmoothOptimizers:mainfrom
MaxenceGollier:update-breakage

Conversation

@MaxenceGollier

Copy link
Copy Markdown
Contributor

Copilot AI review requested due to automatic review settings July 22, 2026 15:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@MaxenceGollier

Copy link
Copy Markdown
Contributor Author

The Breakage.yml looks different from the others here.
From the file blame, #212 seems to be the reason for this. @amontoison let me know if something has to be done here, I can write a different breakage workflow specific to this package if needed.

@amontoison

Copy link
Copy Markdown
Member

@MaxenceGollier I did a modification here to see the breakage results from a PR opened with a fork.
I think it is supported by your workflow in https://github.com/JuliaSmoothOptimizers/.github.

@MaxenceGollier

Copy link
Copy Markdown
Contributor Author

Ah, yes indeed.

@amontoison

Copy link
Copy Markdown
Member

@MaxenceGollier Do you know why we don't have the workflow "downgrade" running?
--> https://github.com/JuliaSmoothOptimizers/.github/blob/main/.github/workflows/downgrade-compat.yaml

LGTM for this PR, I merge 👍

@amontoison
amontoison merged commit 5408b98 into JuliaSmoothOptimizers:main Jul 22, 2026
23 checks passed
@MaxenceGollier
MaxenceGollier deleted the update-breakage branch July 22, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants