Use MOI.Nonlinear.ModelWithQuad instead of QPBlockData - #238
Merged
Conversation
Store the parsed quadratic constraints in a MOI.Nonlinear.ModelWithQuad and evaluate them through the corresponding MOI.Nonlinear.EvaluatorWithQuad, instead of using the QPBlockData and its private helpers directly. The per-constraint methods (jth_hess_coord!, jth_hprod! and ghjvprod!) evaluate the Hessian of the Lagrangian of the block with a basis multiplier vector, which removes the per-constraint Hessian offsets. The products of the evaluator overwrite their output, so the Jacobian-transpose and Hessian products go through a new hv workspace before being accumulated.
MOI.Nonlinear.ModelWithQuad now owns the variables of the model, so the parser adds them and the evaluator no longer takes ordered_variables.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of concept refactor after