-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct coeftable for GLMMs, add tests #308
Conversation
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
+ Coverage 95.69% 95.97% +0.27%
==========================================
Files 20 21 +1
Lines 1510 1515 +5
==========================================
+ Hits 1445 1454 +9
+ Misses 65 61 -4
Continue to review full report at Codecov.
|
It looks as if the identical parameter estimates for the Laplace approximation and the nAGQ=11 fit for the goldstein data may be a coincidence. Fitting such models to the contra data does produce slightly different values for the parameter estimates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're now missing StatsBase.vcov
for GeneralizedLinearMixedModel
and I'm wondering if it makes sense to gather up all the methods defined for the superclass MixedModel
into one place.
@palday Will you have the opportunity to look at the latest commit to see if it addresses the questions you had? |
There are a couple of spots where the superclass methods aren't there yet ( |
Ah, can't do it for the cherry picking after all -- the |
Ah, so good news -- the |
* correct coeftable for GLMMs, add tests * Move methods for abstract MixedModel struct to separate file. (cherry picked from commit 5fb6f65)
* warning for GLMM with dispersion parameter (#373)* warning for GLMM with dispersion parameter(cherry picked from commit 66b8863) * correct coeftable for GLMMs, add tests (#308) * Move methods for abstract MixedModel struct to separate file. (cherry picked from commit 5fb6f65) * chang CoefTable column names to match GLM.jl * ranef method for GLMM (#336) (cherry picked from commit 753aa6f) * make (1|x) + (y|x) equivalent to (1|x) + (0+y|x) (#338) * fix error with (1|x) + (y|x) * fix typo (cherry picked from commit 20c83ef) * update ranef docstring Co-authored-by: Douglas Bates <[email protected]>
See #307
Note that the example for this PR ("goldstein") still has the peculiar property that the deviances change between the Laplace approximation and
nAGQ=11
but the parameter estimates are exactly the same. Now the multipliers,m11.mult
are all close to 1.0 but not that close.I don't think this is right still