-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify PDMat
and PDSparseMat
+ move SparseArrays support to an extension
#188
Open
devmotion
wants to merge
18
commits into
master
Choose a base branch
from
dw/unify_pdmat_pdsparsemat
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+333
−372
Open
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5ab9584
Unify `PDMat` and `PDSparseMat`
devmotion e4ed4ed
Replace tab with whitespace
devmotion 91f6d14
Try to add back support for Julia < 1.9
devmotion e817ceb
Fix support on older Julia versions
devmotion dee9225
Merge branch 'master' into dw/unify_pdmat_pdsparsemat
devmotion dd947d6
Fix test errors on Julia 1.0
devmotion 2dc005d
Update README.md
devmotion deb575d
Improve type parameter
devmotion c27aab2
Rename field `chol` to `fact`
devmotion 578e459
Merge branch 'master' into dw/unify_pdmat_pdsparsemat
devmotion 6ce4b77
Fix type parameter
devmotion bbedcb2
Fix variable conflicts with type parameters
devmotion dca9273
Clean up switch to `fact`
devmotion 33a80f3
Specialize `sqrt` for `PDSparseMat`
devmotion 60df321
Merge branch 'master' into dw/unify_pdmat_pdsparsemat
devmotion 6678dd3
Merge branch 'master' into dw/unify_pdmat_pdsparsemat
devmotion a0acc49
Add test from #207
devmotion 8c160df
Run `SymTridiagonal` tests only on Julia >= 1.8
devmotion File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably want to add tests for what happens if one tries to construct with factorizations besides cholesky.