Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify PDMat and PDSparseMat + move SparseArrays support to an extension #188

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test from #207
devmotion committed Aug 5, 2024
commit a0acc4912c738295708dad62a8fcef68b46aebbc
8 changes: 8 additions & 0 deletions test/pdmtypes.jl
Original file line number Diff line number Diff line change
@@ -304,4 +304,12 @@ using Test
@test_broken C - B isa Diagonal{Float64, Vector{Float64}}
@test C - B ≈ Matrix(C) - Matrix(B)
end

# https://github.com/JuliaStats/PDMats.jl/pull/207
@testset "PDMat from SymTridiagonal" begin
S = SymTridiagonal(fill(4, 4), fill(1, 3))
M = @inferred(PDMat(S))
@test M isa PDMat{Int,<:SymTridiagonal,<:Cholesky}
@test M == S
end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want to add tests for what happens if one tries to construct with factorizations besides cholesky.

end