Fix convert for ScalMat - #210
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
==========================================
- Coverage 91.61% 91.37% -0.24%
==========================================
Files 9 8 -1
Lines 680 638 -42
==========================================
- Hits 623 583 -40
+ Misses 57 55 -2 ☔ View full report in Codecov by Sentry. |
devmotion
added a commit
that referenced
this pull request
Jun 24, 2026
Resolve conflicts from master, preserving all master improvements while keeping the PR's unification of `PDMat`/`PDSparseMat` and the SparseArrays package extension. Key resolutions: - `PDMat` keeps the generalized 3-parameter struct (`mat::S`, `fact::F`); master's coercing constructors and `convert` methods are re-expressed against `fact`/`cholesky(...)` (with an added 3-parameter `convert`). - Dense Cholesky operations stay on the general `PDMat`; `cholesky` is the only method restricted to the `PDMatCholesky` alias. The sparse extension overrides the CHOLMOD-specific methods by dispatch. - Master's sparse `invwhiten`/`invunwhiten` methods and modernized `quad`/`quad!` are folded into the extension's `pdsparsemat.jl`; generic sparse operations now flow through the unified core `PDMat` methods. - `congruence.jl` and `StatsBaseExt.jl` are narrowed to `PDMatCholesky` and switched from `.chol` to the `cholesky(...)` accessor (avoids catching sparse matrices and resolves dispatch ambiguities). - Preserved master features: coercing constructors/convert (#212, #210), `invwhiten`/`invunwhiten` (#221), `ldiv!` (#228), the `kron` fix (#218), ForwardDiff-safe `whiten!`/`unwhiten!` (#217), `congruence.jl`, the StatsBase extension, and the Runic formatting (#220). - Dropped pre-1.9 / Julia-1.0 compat shims (compat is now Julia >= 1.10); dropped the now-unused SuiteSparse dependency. - Fixed a latent dead `quad`/`invquad` specialization (`<:Vector` -> `Matrix{T}`). - Version bumped to 0.12.0 (breaking: `PDMat` struct parameters changed). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #211.