Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw appropriate error for pad_sequence input of length > maxlen #186

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Throw appropriate error for pad_sequence input of length > maxlen #186

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0b1a3e
Update sentiment.jl
sean-gauss Jan 15, 2020
a190c9c
Update sentiment.jl
sean-gauss Jan 18, 2020
63ddb7c
Update sentiment.jl
sean-gauss Feb 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/sentiment.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ function pad_sequences(l, maxlen=500)
push!(res, ele)
end
return res
end
else
length(1) > maxlen || throw("String length exceeds maximum length")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

length(1) => length(l)?

Also, why are we checking this condition again? length(l) > maxlen

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the checking condition be &&? even in that case?

end
Ayushk4 marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
end
end

Indentation

end

function read_weights(filename=sentiment_weights)
Expand Down