Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enabled=showprogress #284

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Use enabled=showprogress #284

merged 3 commits into from
Sep 6, 2024

Conversation

prbzrg
Copy link
Contributor

@prbzrg prbzrg commented Aug 18, 2024

You should use enabled=showprogress to disable progressbar, instead of infinite dt.
I also combined for loops.

@rssdev10
Copy link
Collaborator

rssdev10 commented Sep 1, 2024

Hi, thank you for the commit. But please avoid mixing style changes / indentations with functional changes. Do I understand correctly that only one line has been changed with enabled=showprogress? Others for decoration only. Can you remove it from the commit?

@prbzrg
Copy link
Contributor Author

prbzrg commented Sep 6, 2024

OK, I reverted that.

@rssdev10 rssdev10 merged commit d69315b into JuliaText:master Sep 6, 2024
7 checks passed
@rssdev10
Copy link
Collaborator

rssdev10 commented Sep 6, 2024

thanks

@prbzrg prbzrg deleted the fix-pb branch September 6, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants