Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant space insertion in text (fix #100) #101

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Remove redundant space insertion in text (fix #100) #101

merged 3 commits into from
Jan 2, 2025

Conversation

thchr
Copy link
Contributor

@thchr thchr commented Feb 28, 2024

Implemented the change I suggested in #100 and added the two corresponding tests.

@thchr thchr mentioned this pull request Dec 21, 2024
Closed
@JamesWrigley
Copy link
Contributor

SGTM, though I'm not an expert. @aviks, @pfitzseb, any objections to merging this?
(nerd-sniping you both since you've made recent-ish contributions :) )

pfitzseb
pfitzseb approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@pfitzseb pfitzseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JamesWrigley JamesWrigley merged commit 78f07cb into JuliaWeb:master Jan 2, 2025
6 checks passed
@thchr thchr deleted the patch-1 branch January 2, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfitzseb pfitzseb pfitzseb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thchr @JamesWrigley @pfitzseb