Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 76.80% 70.74% -6.06%
==========================================
Files 2 2
Lines 1095 1128 +33
==========================================
- Hits 841 798 -43
- Misses 254 330 +76 ☔ View full report in Codecov by Sentry. |
Contributor
|
Not all of those ciphers are legacy ones... |
fxcoudert
reviewed
Apr 7, 2024
| # https://www.openssl.org/docs/man3.0/man7/OSSL_PROVIDER-legacy.html | ||
| @testset "Encrypt" begin | ||
| if OpenSSL.version_number() ≥ v"3" | ||
| OpenSSL.load_legacy_provider() |
There was a problem hiding this comment.
The load_legacy_provider function and associated code would go away, I suppose.
fxcoudert
reviewed
Apr 7, 2024
| EvpBlowFishECB(), # legacy | ||
| #EvpBlowFishCFB(), // not supported | ||
| EvpBlowFishOFB(), # legacy | ||
| EvpAES128CBC(), |
There was a problem hiding this comment.
EvpAES128CBC, EvpAES128ECB and EvpAES128OFB aren't marked as legacy and should remain.
fxcoudert
reviewed
Apr 7, 2024
| end | ||
|
|
||
| @testset "EncryptCustomKey" begin | ||
| # EvpBlowFishECB is legacy, consider using EvpAES128ECB instead |
There was a problem hiding this comment.
Instead of being removed, this test could be moved to a non-legacy cipher as suggested in the comment.
|
@quinnj gentle bump: could you please have a look at the comments above? 🙂 |
quinnj
force-pushed
the
jq-remove-legacy-tests
branch
from
9734554 to
e6cdfd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For context, see discussion in JuliaLang/julia#53891