Skip to content

Conversation

@deltadecay
Copy link

Hello,
I've added support for EC key pairs and method to generate one from builtin curve id or name.

Example:

using OpenSSL
#curves = ec_builtin_curves()

eckey = EvpPKey(ec_generate_key("secp256k1"))

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 94.23077% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.81%. Comparing base (10f7b7b) to head (49c6876).
⚠️ Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/OpenSSL.jl 94.23% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   77.56%   75.81%   -1.76%     
==========================================
  Files           2        2              
  Lines        1083     1170      +87     
==========================================
+ Hits          840      887      +47     
- Misses        243      283      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aviks
Copy link
Member

aviks commented Dec 2, 2025

So this fails for our integration tests with OpenSSL v1.x -- can you address those somehow?

@deltadecay
Copy link
Author

The integration tests pass now, but not codecov. Any recommendations how to write tests that check failure of the ccalls?

@aviks
Copy link
Member

aviks commented Dec 10, 2025

Eh, if the patch coverage is better than project coverage, I think it can be merged. I'll take a closer look tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants