Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leading slash for abspath in joinpath #62

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix leading slash for abspath in joinpath #62

wants to merge 2 commits into from

Conversation

pb866
Copy link

@pb866 pb866 commented Dec 28, 2024 •
edited
Loading

Currently, joinpath gives two leading slashes, when an absolute path is joined to an empty URI path. This PR fixes this issue.

julia> using URIs

julia> u = URI("http://test.com")
URI("http://test.com")

julia> joinpath(u, "/abs/path")
URI("http://test.com//abs/path")

pb866 added 2 commits December 28, 2024 22:56
@pb866
Fix leading slash for abspath in joinpath
f9ad5d8 
Signed-off-by: Peter Bräuer <[email protected]>
@pb866
Add unit tests
a9506cd 
Add tests to add absolut path with and without trailing slash and
absolut path with additional part to an empty uri path.

Signed-off-by: Peter Bräuer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pb866