Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepared buffers #102

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: prepared buffers #102

wants to merge 6 commits into from

Conversation

Julusian
Copy link
Owner

The aim of this is to better support users who want to do rapid drawing of the same buffers, such as to achieving flashing or gif behaviour.

This is a performance optimisation by allowing them to 'prepare' a draw, which does all the buffer preparation and jpeg encoding necessary, and then repeatedly send the draw when wanted much cheaper than before.

The prepared buffer can be optionally made json safe, where the buffers will be encoded as a string at the cost of requiring it to be decoded each time it is drawn

@Julusian Julusian force-pushed the feat/prepared-buffers branch from a45def5 to b954be0 Compare February 16, 2025 17:09
@Julusian Julusian marked this pull request as ready for review February 16, 2025 17:09
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 21.73913% with 72 lines in your changes missing coverage. Please review.

Project coverage is 35.71%. Comparing base (7fdbe37) to head (820cf35).

Files with missing lines Patch % Lines
packages/core/src/preparedBuffer.ts 11.11% 14 Missing and 2 partials ⚠️
...ckages/core/src/services/lcdSegmentDisplay/plus.ts 14.28% 11 Missing and 1 partial ⚠️
...ges/core/src/services/buttonsLcdDisplay/default.ts 52.17% 11 Missing ⚠️
packages/core/src/models/base.ts 9.09% 9 Missing and 1 partial ⚠️
packages/core/src/proxy.ts 0.00% 8 Missing ⚠️
packages/tcp/src/index.ts 0.00% 6 Missing ⚠️
...kages/core/src/services/buttonsLcdDisplay/pedal.ts 0.00% 4 Missing ⚠️
packages/webhid/src/index.ts 0.00% 3 Missing ⚠️
...ackages/core/src/services/lcdSegmentDisplay/neo.ts 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
- Coverage   36.55%   35.71%   -0.84%     
==========================================
  Files          51       52       +1     
  Lines        1625     1705      +80     
  Branches      215      234      +19     
==========================================
+ Hits          594      609      +15     
+ Misses       1031     1015      -16     
- Partials        0       81      +81     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants