Implement Get Pokemon by HP (Fix Issue developer-job-simulation#4)

README.md

@@ -7,7 +7,7 @@ This is an Express JS Pokemon API based on PokeAPI. Your job is to fix 4 issues:
 1. ~~Implement Get Pokemon by ID~~
 1. ~~Implement Get Pokemon by Name~~
 1. ~~Implement Get Pokemon by Type~~
-1. Implement Get Pokemon by HP (with Query Params)
+1. ~~Implement Get Pokemon by HP (with Query Params)~~
 
 Please refer to the API Swagger documentation for clear specifications of the API's intended behavior. You can find the Swagger docs at http://localhost:3000/api-docs.
 

src/routes/pokemon.js

@@ -7,6 +7,37 @@ router.get("/", function (req, res, next) {
   res.json(pokedex);
 });
 
+/* GET Pokemon by HP */
+router.get("/hp", function (req, res, next) {
+  const validComparators = new Set(["lt", "gt", "lte", "gte"]);
+  const comparators = req.query;
+  const comparatorKeys = Object.keys(comparators);
+  for (let i = 0; i < comparatorKeys.length; i++) {
+    if (!validComparators.has(comparatorKeys[i]))
+      return res.status(400).json({
+        error: 'Invalid Operator. Must be one of ["gt","gte","lt","lte"]',
+      });
+  }
+  const comparatorToFn = {
+    lt: (l, r) => l < r,
+    gt: (l, r) => l > r,
+    lte: (l, r) => l <= r,
+    gte: (l, r) => l >= r,
+  };
+  function inHPRange(hp) {
+    for (const [comp, value] of Object.entries(comparators)) {
+      if (!comparatorToFn[comp](hp, Number(value))) return false;
+    }
+    return true;
+  }
+  const pokemons = pokedex.filter((el) => inHPRange(el.base.HP));
+
+  if (!pokemons || pokemons.length === 0)
+    return res.status(404).json({ error: "Not found" });
+
+  return res.status(200).json(pokemons);
+});
+
 /* GET Pokemon by Id. */
 router.get("/:id", function (req, res, next) {
   const { id } = req.params;
@@ -16,7 +47,7 @@ router.get("/:id", function (req, res, next) {
   const pokemon = pokedex.find((el) => el.id === Number(id));
   if (!pokemon) return res.status(404).json({ error: "Not found" });
 
-  console.log(pokemon);
+  // console.log(pokemon);
   return res.status(200).json(pokemon);
 });
 
@@ -42,11 +73,4 @@ router.get("/type/:type", function (req, res, next) {
   return res.status(200).json(pokemons);
 });
 
-/* GET Pokemon by HP */
-router.get("/hp", function (req, res, next) {
-  // TODO: Implement this route. See swagger docs for details, by visiting http://localhost:3000/api-docs
-  res.status(501).json({ message: "Not Implemented" });
-  return;
-});
-
 module.exports = router;