Fix Issue developer-job-simulation#4

JunYuHuang · Apr 10, 2023 · 77d640d · 77d640d
1 parent fc37810
commit 77d640d
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -7,7 +7,7 @@ This is a simple E-Commerce site made with React and TailwindCSS. Your job is to
 1. [Sort Products by Price and Release Date](https://github.com/developer-job-simulation/react-ecommerce/issues/1)
 1. [Cart Persistence on Refresh](https://github.com/developer-job-simulation/react-ecommerce/issues/2)
 1. [Add Product Filters Functionality](https://github.com/developer-job-simulation/react-ecommerce/issues/3)
-1. [Product Fetch is Causing Infinite Loop](https://github.com/developer-job-simulation/react-ecommerce/issues/4)
+1. ~~[Product Fetch is Causing Infinite Loop](https://github.com/developer-job-simulation/react-ecommerce/issues/4)~~
 1. [Need to display 'Empty Cart' When Cart is Empty on Cart Page](https://github.com/developer-job-simulation/react-ecommerce/issues/5)
 1. [Update Cart in Nav with Cart Size](https://github.com/developer-job-simulation/react-ecommerce/issues/6)
 1. [Cart not closing when User Clicks Gray Region](https://github.com/developer-job-simulation/react-ecommerce/issues/7)

diff --git a/package-lock.json b/package-lock.json
diff --git a/src/Components/ProductTable.jsx b/src/Components/ProductTable.jsx
@@ -41,7 +41,7 @@ export default function ProductTable({ cart, updateCart }) {
       setProducts(body);
     };
     fetchProducts();
-  });
+  }, []);
 
   return (
     <div className="bg-white">

diff --git a/todo.md b/todo.md
@@ -0,0 +1,12 @@
+<!-- - Issue #1 Todos
+    - [ ] On Click of Sort by Price, products should be sorted by Price.
+    - [ ] On Click of Sort by Newest, products should be sorted by Release Date.
+    
+- Issue #2 Todos
+    - [ ] something
+
+- Issue #3 Todos
+    - something -->
+
+- Issue #4 Todos
+    - [x] Fix the effect hook to stop infinite loop