[xcvrd] Fix issue: do not print error log when module support non-ethernet application #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ernet application
Junchao-Mellanox
force-pushed
the
master-err-log
branch
from
a6d98af to
ac2e3f7
Compare
keboliu
approved these changes
Jun 14, 2024
|
ci 4159 passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In function
get_interface_speed, it will log an error if the application name does not contain a valid speed. However, many modules support both ethernet and non-ethernet (e.g. IB) application, non-ethernet application would not contain a valid speed. For such module, the functionget_interface_speedlogs an error to syslog:Actually, this is not an error because the module will finally find a proper application via the for loop in function
get_cmis_application_desiredMotivation and Context
Remove the unexpected error log since it could be a false alarm. Also, log the module applications if it cannot find a proper application.
How Has This Been Tested?
Manual test
Additional Information (Optional)