Fix for issues #35, #37, #38 #40

vignesh-k · 2018-12-05T13:03:57Z

Issue #35 : For fields which are not predefined in %methods, use the input as it is without changing _ to -.
Issue #37 : Included quotes
Issue #38 : Commented out the print statement.

Additional change : Commented out 'Disconnecting' carp call.

Issue Juniper#35 : For fields which are not predefined in %methods, use the input as it is without changing _ to -. Issue Juniper#37 : Included quotes Issue Juniper#38 : Commented out the print statement. Additional change : Commented out 'Disconnecting' carp call.

ydnath

Why is this change required? Where is tag or field changing in this code path?

vignesh-k · 2018-12-10T14:47:23Z

I assume the question is for fix to Issue #35 at line 566.
The issue as explained is the conversion of underscore(_) to hyphen(-) for the input netconf query parameters.
The change here is to use the variable 'field' which is the actual parameter rather than the variable 'tag' which has underscores changed to hyphens at line 525. This change will be applicable only for fields not predefined in netconf libarary in %methods hash.

ydnath reviewed Dec 10, 2018

View reviewed changes

ydnath merged commit 8f02d35 into Juniper:master Dec 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for issues #35, #37, #38 #40

Fix for issues #35, #37, #38 #40

vignesh-k commented Dec 5, 2018

ydnath left a comment

vignesh-k commented Dec 10, 2018

Fix for issues #35, #37, #38 #40

Fix for issues #35, #37, #38 #40

Conversation

vignesh-k commented Dec 5, 2018

ydnath left a comment

Choose a reason for hiding this comment

vignesh-k commented Dec 10, 2018