Add a new cloudmonitoring target #259
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlevesy
force-pushed
the
jl/support-cloudmonitoring
branch
5 times, most recently
from
b014580
to
45987f3
Compare
jlevesy
force-pushed
the
jl/support-cloudmonitoring
branch
from
45987f3
to
6c380e1
Compare
K-Phoen
reviewed
Apr 11, 2024
| @@ -61,6 +62,14 @@ func WithStackdriverTarget(target *stackdriver.Stackdriver) Option { | |||
| } | |||
| } | |||
|
|
|||
| // WithCloudMonitoringTarget adds a cloud monitoring query to the graph. | |||
| func WithCloudMonitoringTarget(target cloudmonitoring.Target) Option { | |||
There was a problem hiding this comment.
Don't forget to copy-paste this for other panels too :sadness:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new target called
cloudmonitoringwhich implements a way of defining Google Cloud Metrics targets supported by Grafana 10. I did not reuse thestackdrivername, because it isn't used anymore on the actual Google Product.It aims to support the 4 different ways of making queries to CloudMonitoring:
NewTimeSeriesinit function.NewMQLinit functionNewPromQLinit function.NewSLO.Very much a work in progress as I type this message. But just to let you know how I'm planing to deal with it.
Tested this branch against Grafana v10.2.6 (e5ffb9ba46)
Needs K-Phoen/sdk#29 to land before.
TODO list: