Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more QMargins/QMarginsF autotests #744

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

Montel
Copy link
Contributor

@Montel Montel commented Nov 20, 2023

No description provided.

@Montel Montel self-assigned this Nov 20, 2023
@Montel Montel force-pushed the add_qmargins_more_autotest branch from ad8ce16 to 7a50d29 Compare November 20, 2023 16:29
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

ahayzen-kdab
ahayzen-kdab previously approved these changes Nov 21, 2023
@ahayzen-kdab ahayzen-kdab enabled auto-merge (rebase) November 21, 2023 10:42
auto-merge was automatically disabled November 21, 2023 11:04

Rebase failed

@Montel Montel force-pushed the add_qmargins_more_autotest branch from 057c260 to cdd7bb1 Compare November 21, 2023 13:03
@Montel Montel enabled auto-merge (squash) November 21, 2023 13:04
ahayzen-kdab
ahayzen-kdab previously approved these changes Nov 21, 2023
Copy link
Collaborator

@LeonMatthesKDAB LeonMatthesKDAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeonMatthesKDAB LeonMatthesKDAB force-pushed the add_qmargins_more_autotest branch from 05baf1a to cf7d594 Compare November 22, 2023 16:51
@ahayzen-kdab ahayzen-kdab force-pushed the add_qmargins_more_autotest branch from cf7d594 to 253b6a2 Compare November 22, 2023 17:03
@Montel Montel merged commit a95a740 into KDAB:main Nov 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants