Remove ALLOW_PRIVILEGE_ESCALATION

The new elevation system is not prone to the security issues of
the old system, as such we no longer need to have users opt-in
to this functionality anymore.

CMakeLists.txt

@@ -27,7 +27,6 @@ set(CMAKE_CXX_STANDARD 14)
 set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
 option(APPIMAGE_BUILD "configure build for bundling in an appimage" OFF)
-option(ALLOW_PRIVILEGE_ESCALATION "allow temporary privilege escalation" OFF)
 
 # Enable the test harness
 enable_testing()

hotspot-config.h.cmake

@@ -27,5 +27,3 @@
 #cmakedefine01 KGraphViewerPart_FOUND
 
 #cmakedefine01 KF5SyntaxHighlighting_FOUND
-
-#cmakedefine01 ALLOW_PRIVILEGE_ESCALATION

src/perfrecord.cpp

@@ -412,7 +412,7 @@ bool PerfRecord::canCompress()
 
 bool PerfRecord::canElevatePrivileges()
 {
-    return ALLOW_PRIVILEGE_ESCALATION && (!sudoUtil().isEmpty());
+    return !sudoUtil().isEmpty();
 }
 
 QString PerfRecord::perfBinaryPath()

src/recordpage.cpp

@@ -374,11 +374,7 @@ RecordPage::RecordPage(QWidget* parent)
     } else if (!PerfRecord::canElevatePrivileges()) {
         ui->elevatePrivilegesCheckBox->setChecked(false);
         ui->elevatePrivilegesCheckBox->setEnabled(false);
-#if ALLOW_PRIVILEGE_ESCALATION
         ui->elevatePrivilegesCheckBox->setText(tr("(Note: this requires pkexec installed"));
-#else
-        ui->elevatePrivilegesCheckBox->setText(tr("(Note: hotspot is not build with ALLOW_PRIVILEGE_ESCALATION=ON)"));
-#endif
     }
 
     connect(ui->elevatePrivilegesCheckBox, &QCheckBox::toggled, this, &RecordPage::updateOffCpuCheckboxState);