add copy function to disassembly views #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lievenhey
force-pushed
the
select-codedelegate
branch
from
df0982c
to
5e3bdc4
Compare
|
This makes hotspot behave like the user expects. I would be confused if I select multiple cells and only get the last one into my clipboard. |
lievenhey
force-pushed
the
select-codedelegate
branch
2 times, most recently
from
9ccb7ad
to
23f3f65
Compare
milianw
requested changes
Sep 22, 2023
This allows the user to copy text from the sourcecodeview and the disassembly view. This is done by reimplementing QTreeView with a custom keyPressEvent function that copies everything from selectionModel() to the clipboard and not just currentIndex like the default implementation does.
Only the Q_DECLARE_METATYPE part of the headers is used. So there is no need to include them.
lievenhey
force-pushed
the
select-codedelegate
branch
from
23f3f65
to
594b53d
Compare
milianw
requested changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to copy text from the sourcecodeview and the disassembly view. This is done by reimplementing QTreeView with a custom keyPressEvent function that copies everything from selectionModel() to the clipboard and not just currentIndex like the default implementation does.