Use isa and isa_and_nonnull when possible

src/ContextUtils.cpp

@@ -57,7 +57,7 @@ static std::string nameForContext(DeclContext *context)
         return rec->getNameAsString();
     } else if (auto *method = dyn_cast<CXXMethodDecl>(context)) {
         return method->getNameAsString();
-    } else if (dyn_cast<TranslationUnitDecl>(context)) {
+    } else if (isa<TranslationUnitDecl>(context)) {
         return {};
     } else {
         llvm::errs() << "Unhandled kind: " << context->getDeclKindName() << "\n";

src/ContextUtils.h

@@ -55,7 +55,7 @@ namespace clazy
 inline bool isValueDeclInFunctionContext(const clang::ValueDecl *valueDecl)
 {
     const auto *context = valueDecl ? valueDecl->getDeclContext() : nullptr;
-    return context && llvm::isa<clang::FunctionDecl>(context) && !llvm::isa<clang::ParmVarDecl>(valueDecl);
+    return llvm::isa_and_nonnull<clang::FunctionDecl>(context) && !llvm::isa<clang::ParmVarDecl>(valueDecl);
 }
 
 /**

src/checks/level0/strict-iterators.cpp

@@ -131,7 +131,7 @@ bool StrictIterators::handleImplicitCast(ImplicitCastExpr *implicitCast)
     }
 
     auto *p = m_context->parentMap->getParent(implicitCast);
-    if (dyn_cast<CXXOperatorCallExpr>(p)) {
+    if (isa<CXXOperatorCallExpr>(p)) {
         return false;
     }
 

src/checks/level0/temporary-iterator.cpp

@@ -146,7 +146,7 @@ void TemporaryIterator::VisitStmt(clang::Stmt *stm)
             }
 
             Stmt *firstChild = clazy::getFirstChild(impl);
-            if (firstChild && isa<ImplicitCastExpr>(firstChild) && dyn_cast<ImplicitCastExpr>(firstChild)->getCastKind() == CK_LValueToRValue) {
+            if (isa_and_nonnull<ImplicitCastExpr>(firstChild) && dyn_cast<ImplicitCastExpr>(firstChild)->getCastKind() == CK_LValueToRValue) {
                 return;
             }
         }